Skip to content

turn off smooth if there are too few unique values for splines#167

Merged
topepo merged 9 commits into
mainfrom
spine-to-linear-few-unique
May 13, 2025
Merged

turn off smooth if there are too few unique values for splines#167
topepo merged 9 commits into
mainfrom
spine-to-linear-few-unique

Conversation

@EmilHvitfeldt

@EmilHvitfeldt EmilHvitfeldt commented May 13, 2025

Copy link
Copy Markdown
Member

To close #155

This change happens if the number of unique within any of the groups is too low. To avoid a complicated "some groups use splines some do not" structure that would need to be added

@topepo

topepo commented May 13, 2025

Copy link
Copy Markdown
Member

Thanks! I made some changes to work with the refactored version. For example, we are not bothering with grouped data frames, estimate is a character vector, tidyselect happens early, etc.

@topepo topepo merged commit aa78ab7 into main May 13, 2025
13 checks passed
@topepo topepo deleted the spine-to-linear-few-unique branch May 13, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

have spline-based calibrators revert to linear methods if there are failures

2 participants