Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider handling of locale for step_date() #1048

Closed
juliasilge opened this issue Oct 17, 2022 · 1 comment · Fixed by #1051
Closed

Reconsider handling of locale for step_date() #1048

juliasilge opened this issue Oct 17, 2022 · 1 comment · Fixed by #1051

Comments

@juliasilge
Copy link
Member

In #1000 step_date() was changed so the locale is recorded at prep() and then enforced at bake(). It turns out this presents problems for deploying a trained model to a different infrastructure. I noticed this when training a model on macOS (where I have en_US.UTF-8) and the trying to deploy on Linux. You can see how the problem plays out here.

That workflow (training locally on macOS, deploying on Linux) is pretty common but there are apparently more complex problems when Windows is involved.

The locale is only used for names of days of the week and months of the year, so is it possible we don't need the full locale system? Can we use clock instead?

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant