step_dummy allow all_predictors()

[kagray]

Reminder to review all_predictors() to be used in step_dummy

[topepo]

What was the alternative that we discussed? It would be easy to ignore those that are not factors (and write a warning).

[kagray]

I think that is exactly what we discussed. To simplify the process allow all_predictors and ignore numeric values. On Sep 1, 2018, at 5:49 PM, Max Kuhn <notifications@github.com<mailto:notifications@github.com>> wrote: What was the alternative that we discussed? It would be easy to ignore those that are not factors (and write a warning). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://clicktime.symantec.com/a/1/1IDDNYoNMwcSeKkMWAngX5zy2gatE5aJcAsGxpl3fy8=?d=7N-K9GMA0spvLeBrpOk4mM01On_VfLBn0BOnjq5I9cyJdK49-La7GucDssO53awLmISPemtmupZkBMQA83FNjuqaYNVSUCpYGYJaYr0BY35mqlLRD9IKVNL9f8UV2ridwWKuxdkYSfQUeQWuQr12d2puCNppnDqxmsAEHrO6KbxYfNGWtCRpR3u4rshSJR8Colbu9hSP9DoZBJaU6o6wOk-cUI_kB2Z9jwwlpdXVlCSargj58zP7emUod75QICJ_6fmegT0ncKz_5P4i2qiTD4fAT-qUOIArEeBT5zJ9SZx_Ntvd-EvgbcUTm447-x7n3WAuIGsYycFtI2IhA1Y7zJ2XaeUHjmeG2UM9fd1K5lhnPbaLLx4zJU7s8b5Vnk_0wnT2nVWJvLM8di3Aue_I3t9x5jjGYuY9ixWuzsG6yZU%3D&u=https%3A%2F%2Fgithub.com%2Ftidymodels%2Frecipes%2Fissues%2F186%23issuecomment-417889387>, or mute the thread<https://clicktime.symantec.com/a/1/DRIxBmvpA15XfmvuVPjf9JER9cii_cBmPTwyigmlhiM=?d=7N-K9GMA0spvLeBrpOk4mM01On_VfLBn0BOnjq5I9cyJdK49-La7GucDssO53awLmISPemtmupZkBMQA83FNjuqaYNVSUCpYGYJaYr0BY35mqlLRD9IKVNL9f8UV2ridwWKuxdkYSfQUeQWuQr12d2puCNppnDqxmsAEHrO6KbxYfNGWtCRpR3u4rshSJR8Colbu9hSP9DoZBJaU6o6wOk-cUI_kB2Z9jwwlpdXVlCSargj58zP7emUod75QICJ_6fmegT0ncKz_5P4i2qiTD4fAT-qUOIArEeBT5zJ9SZx_Ntvd-EvgbcUTm447-x7n3WAuIGsYycFtI2IhA1Y7zJ2XaeUHjmeG2UM9fd1K5lhnPbaLLx4zJU7s8b5Vnk_0wnT2nVWJvLM8di3Aue_I3t9x5jjGYuY9ixWuzsG6yZU%3D&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKfU5bmqwN7IiwtTkQ0V4B-UTwhET7SSks5uWwDOgaJpZM4WKC3D>. This communication (including any attachments) is confidential and is intended to be privileged pursuant to applicable law. If you are not the intended recipient, or the employee or agent responsible for delivering it to the intended recipient, then you are hereby notified that the dissemination, distribution or copying of this communication is prohibited. If you received this communication in error, please notify Smithfield Foods, Inc. immediately by telephone (+1 757-365-3000) and then delete this communication and destroy all copies thereof.

[topepo]

I think that is exactly what we discussed. To simplify the process allow all_predictors and ignore numeric values.

Non-factors includes character data too (fyi)

[topepo]

Give that a try and test on your own data.

[kagray]

Ok will do thanks Kent Gray, Ph.D. Director of Genetic Research and Development Smithfield Premium Genetics Office: (910) 282-4227 Cell: (919) 609-6858 kgray@smithfield.com From: Max Kuhn <notifications@github.com> Reply-To: tidymodels/recipes <reply@reply.github.com> Date: Monday, September 3, 2018 at 6:59 PM To: tidymodels/recipes <recipes@noreply.github.com> Cc: Kent Gray <kgray@smithfield.com>, Author <author@noreply.github.com> Subject: Re: [tidymodels/recipes] step_dummy allow all_predictors() (#186) Give that a try and test on your own data. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://clicktime.symantec.com/a/1/13_hVK1wx7sua6K_9RKK6_J0qZbBOsNmCsXfaoOEEP8=?d=HBd9tKn3ZQhBVlcvTkcZSVu70uvc19l5bUI9nPG61Nb6jKcAC_jgR2hb_t0X5sUlGYEJLVj_XoDhlcunWHt9PmYS4Pw_8iZToVTM9eA53qqcbTDILC0eINMHyzoDcBMpwmMS13vSAMSfvUPQzT9CMTxUjsPo0qxB0MUwldOctQgljSpus7LRrf5iq3WYU6jqqL_mxB_oBDEXm3NKuKw_WpBf-5Bx3qCMs-sSa_1Zl8K28bl3b6Wy9lyyGnF9QSYIlknn9t3MQqA6kWhTPhh_RmDiFU8BtjfzHJp8ZfIhzC57p1YpzUEcSBTz4YS2sQZ3qsRAHEAxDHgpZkig86Ff0p9DZI364yJs2uC20aptZRFh1qeTjRCBK3DApC7GfoCTROE8j47fUUA7q-ct62A6WyqyBcyu_FdaMWX6BJtwIhuP&u=https%3A%2F%2Fgithub.com%2Ftidymodels%2Frecipes%2Fissues%2F186%23issuecomment-418202834>, or mute the thread<https://clicktime.symantec.com/a/1/BWcJTJbxQXd5m1n3jwujLbckfzqY7yb28SxHy1dbKjE=?d=HBd9tKn3ZQhBVlcvTkcZSVu70uvc19l5bUI9nPG61Nb6jKcAC_jgR2hb_t0X5sUlGYEJLVj_XoDhlcunWHt9PmYS4Pw_8iZToVTM9eA53qqcbTDILC0eINMHyzoDcBMpwmMS13vSAMSfvUPQzT9CMTxUjsPo0qxB0MUwldOctQgljSpus7LRrf5iq3WYU6jqqL_mxB_oBDEXm3NKuKw_WpBf-5Bx3qCMs-sSa_1Zl8K28bl3b6Wy9lyyGnF9QSYIlknn9t3MQqA6kWhTPhh_RmDiFU8BtjfzHJp8ZfIhzC57p1YpzUEcSBTz4YS2sQZ3qsRAHEAxDHgpZkig86Ff0p9DZI364yJs2uC20aptZRFh1qeTjRCBK3DApC7GfoCTROE8j47fUUA7q-ct62A6WyqyBcyu_FdaMWX6BJtwIhuP&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKfU5bspUfMje0wkb-NSxP7cSLVrhu5Nks5uXbRjgaJpZM4WKC3D>. This communication (including any attachments) is confidential and is intended to be privileged pursuant to applicable law. If you are not the intended recipient, or the employee or agent responsible for delivering it to the intended recipient, then you are hereby notified that the dissemination, distribution or copying of this communication is prohibited. If you received this communication in error, please notify Smithfield Foods, Inc. immediately by telephone (+1 757-365-3000) and then delete this communication and destroy all copies thereof.

[github-actions]

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue.