Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step_dummy allow all_predictors() #186

Closed
kagray opened this issue Aug 23, 2018 · 5 comments
Closed

step_dummy allow all_predictors() #186

kagray opened this issue Aug 23, 2018 · 5 comments

Comments

@kagray
Copy link

@kagray kagray commented Aug 23, 2018

Reminder to review all_predictors() to be used in step_dummy

@topepo
Copy link
Collaborator

@topepo topepo commented Sep 1, 2018

What was the alternative that we discussed? It would be easy to ignore those that are not factors (and write a warning).

@kagray
Copy link
Author

@kagray kagray commented Sep 1, 2018

@topepo
Copy link
Collaborator

@topepo topepo commented Sep 1, 2018

I think that is exactly what we discussed. To simplify the process allow all_predictors and ignore numeric values.

Non-factors includes character data too (fyi)

@topepo topepo closed this in 7d37bf1 Sep 3, 2018
@topepo
Copy link
Collaborator

@topepo topepo commented Sep 3, 2018

Give that a try and test on your own data.

@kagray
Copy link
Author

@kagray kagray commented Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.