Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export additional helper functions #250

Closed
topepo opened this issue Nov 14, 2018 · 7 comments · Fixed by #362
Closed

export additional helper functions #250

topepo opened this issue Nov 14, 2018 · 7 comments · Fixed by #362
Labels
tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day

Comments

@topepo
Copy link
Member

topepo commented Nov 14, 2018

format_selectors and format_ch_vec

@topepo topepo added the tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day label Dec 10, 2018
@khailper
Copy link

khailper commented Jan 19, 2019

Edit: Given the documentation these functions will need, I'm withdrawing my claim on this issue so someone with a better understanding of recipes can tackle it.

I'll claim this one.

@khailper
Copy link

format_selectors has a wdth parameter, but format_ch_vec uses width for the same purpose. Should I edit the source code to make the variable names consistent?

@DavisVaughan
Copy link
Member

For the issue solver:

  • Unify the argument names: wdth -> width
  • Remove the ... from format_selectors()
  • Can the name of format_ch_vec() be more informative?
  • These changes mean you will also have to modify the internal usage of these functions to make sure they are still working correctly

@topepo
Copy link
Member Author

topepo commented Jul 8, 2019

@khailper If you want, go ahead and export them then I can edit the PR with the documentation (after I get out of a meeting in about an hour).

@khailper
Copy link

khailper commented Jul 8, 2019

  • Can the name of format_ch_vec() be more informative?

@DavisVaughan maybe format_chr_vec() as an alternative? (in the vein of purrr::map_chr())

@khailper
Copy link

I'm going to submit the PR without changing the name of format_ch_vec(), but if we can converge on a new name, then I'd be happy to update the relevant internal usage.

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants