Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better naming for step_classdist and step_depth #262

Closed
topepo opened this issue Nov 23, 2018 · 5 comments
Closed

Better naming for step_classdist and step_depth #262

topepo opened this issue Nov 23, 2018 · 5 comments
Labels
tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day

Comments

@topepo
Copy link
Member

topepo commented Nov 23, 2018

From #261 add an options similar to step_dummy or step_pca that allows for more flexibility when naming the new variables. Do the same for step_depth.

@topepo topepo added the tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day label Dec 10, 2018
@gdequeiroz
Copy link
Contributor

On it!

@gdequeiroz
Copy link
Contributor

gdequeiroz commented Jan 19, 2019

Progress

  • Add argument prefix to thestep_classdist function
  • Add document to reflect the change
  • Add example of the new use case (when using prefix)
  • Add tests
  • Add argument prefix to the step_depth function
  • Add document to reflect the change
  • Add tests

For Future

  • Create a better error or a recommendation for the prefix argument.

@juliasilge
Copy link
Member

This is closed in #468. Thank you so much @gdequeiroz! 👯‍♀️

@gdequeiroz
Copy link
Contributor

@juliasilge Thank you for doing the work and closing this!

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day
Projects
None yet
Development

No branches or pull requests

3 participants