Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow empty selections for some steps #290

Closed
topepo opened this issue Mar 1, 2019 · 2 comments
Closed

allow empty selections for some steps #290

topepo opened this issue Mar 1, 2019 · 2 comments

Comments

@topepo
Copy link
Collaborator

@topepo topepo commented Mar 1, 2019

If step_other, step_dummy, step_corr, step_linearcomb and a few others have selectors that do not return any columns, go ahead and return the data as-is.

@AnselmJeong
Copy link

@AnselmJeong AnselmJeong commented Apr 12, 2019

Yes, step_dummy allows empty selection, so you can define like step_dummy(all_nominal()) with a data.frame containing no factor variables. But it did not help anyway, because it still fails at the prep stage.

@topepo
Copy link
Collaborator Author

@topepo topepo commented Jun 28, 2019

@AnselmJeong please test; I just committed a PR that may have solved this for you.

topepo added a commit that referenced this issue Jun 28, 2019
topepo added a commit that referenced this issue Jun 29, 2019
changes for #338 and #290
@topepo topepo closed this Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.