Skip to content

/ recipes

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can `step_knnimpute` be parallelized? #323

Closed
johanneswaage opened this issue Apr 25, 2019 · 2 comments
Closed

Can `step_knnimpute` be parallelized? #323

johanneswaage opened this issue Apr 25, 2019 · 2 comments

Comments

@johanneswaage
Copy link

@johanneswaage johanneswaage commented Apr 25, 2019

Right now, step_knnimpute uses only one thread, and can take a long time for datasets with a large number of features. Could threads be passed to the underlying distance function for any gains?
Thanks
@topepo
Copy link
Collaborator

@topepo topepo commented Apr 25, 2019

The underlying function has an option for threading. I'll add a options argument so that you can pass options to gower::gower_topn().
topepo added a commit that referenced this issue Apr 25, 2019
@topepo
knn changes for #323
Loading status checks…
a75c3b2
topepo added a commit that referenced this issue Jun 27, 2019
@topepo
Merge pull request #324 from tidymodels/gower-options
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
eb70aef 
Gower options for #323
@topepo
Copy link
Collaborator

@topepo topepo commented Jun 29, 2019

Done
@topepo topepo closed this Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@johanneswaage @topepo
You can’t perform that action at this time.