Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argument for retaining original in step_dummy #328

Closed
EdwinTh opened this issue May 6, 2019 · 3 comments
Closed

argument for retaining original in step_dummy #328

EdwinTh opened this issue May 6, 2019 · 3 comments

Comments

@EdwinTh
Copy link
Contributor

EdwinTh commented May 6, 2019

As also noted in the Description, step_dummy removes the original variable. I think it would be valuable to have the option to retain it. Personally, I always keep keep my characters/factors in the modelling set to do post-model analyses.

Happy to do a PR, please let me know how you feel about this.

@topepo
Copy link
Member

topepo commented Jun 28, 2019

Changes have been checked in if you want to test

@topepo topepo closed this as completed Jun 28, 2019
@EdwinTh
Copy link
Contributor Author

EdwinTh commented Jul 1, 2019

Great, does look good to me!

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants