Skip to content

/ recipes

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

argument for retaining original in `step_dummy` #328

Closed
EdwinTh opened this issue May 6, 2019 · 2 comments
Closed

argument for retaining original in `step_dummy` #328

EdwinTh opened this issue May 6, 2019 · 2 comments

Comments

@EdwinTh
Copy link
Contributor

@EdwinTh EdwinTh commented May 6, 2019

As also noted in the Description, step_dummy removes the original variable. I think it would be valuable to have the option to retain it. Personally, I always keep keep my characters/factors in the modelling set to do post-model analyses.

Happy to do a PR, please let me know how you feel about this.
topepo added a commit that referenced this issue Jun 28, 2019
@topepo
options for retaining original columns for #328
Loading status checks…
6cbab1b
@topepo topepo mentioned this issue Jun 28, 2019
Merged
@topepo
Copy link
Collaborator

@topepo topepo commented Jun 28, 2019

Changes have been checked in if you want to test
@topepo topepo closed this Jun 28, 2019
@EdwinTh
Copy link
Contributor Author

@EdwinTh EdwinTh commented Jul 1, 2019

Great, does look good to me!
@EdwinTh EdwinTh mentioned this issue Jan 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@topepo @EdwinTh
You can’t perform that action at this time.