Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in tidy.step_nnmf() #665

Closed
EmilHvitfeldt opened this issue Mar 11, 2021 · 1 comment · Fixed by #672
Closed

Error in tidy.step_nnmf() #665

EmilHvitfeldt opened this issue Mar 11, 2021 · 1 comment · Fixed by #672
Labels
bug an unexpected problem or unintended behavior

Comments

@EmilHvitfeldt
Copy link
Member

Reprex:

library(tidymodels)
#> ── Attaching packages ────────────────────────────────────── tidymodels 0.1.1 ──
#> ✓ broom     0.7.2           ✓ recipes   0.1.15.9000
#> ✓ dials     0.0.9           ✓ rsample   0.0.9      
#> ✓ dplyr     1.0.5           ✓ tibble    3.1.0      
#> ✓ ggplot2   3.3.3           ✓ tidyr     1.1.3      
#> ✓ infer     0.5.3           ✓ tune      0.1.3.9000 
#> ✓ modeldata 0.1.0           ✓ workflows 0.2.1.9000 
#> ✓ parsnip   0.1.5.9001      ✓ yardstick 0.0.7      
#> ✓ purrr     0.3.4
#> ── Conflicts ───────────────────────────────────────── tidymodels_conflicts() ──
#> x purrr::discard() masks scales::discard()
#> x dplyr::filter()  masks stats::filter()
#> x dplyr::lag()     masks stats::lag()
#> x recipes::step()  masks stats::step()
rec <- recipe(~., data = mtcars) %>%
  step_nnmf(all_predictors()) %>%
  prep()

tidy(rec, 1)
#> Error: Input must be a vector, not NULL.

Created on 2021-03-11 by the reprex package (v0.3.0)

Haven't double-checked, but I think this

var_names <- colnames(x$res@other.data$H)

should be changed to

var_names <- colnames(x$res@other.data$w)
@hfrick hfrick added the bug an unexpected problem or unintended behavior label Mar 11, 2021
@github-actions
Copy link

github-actions bot commented Apr 9, 2021

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants