Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take fastICA out of Suggests #823

Closed
topepo opened this issue Sep 27, 2021 · 3 comments
Closed

Take fastICA out of Suggests #823

topepo opened this issue Sep 27, 2021 · 3 comments
Labels
next release 🚀 upkeep maintenance, infrastructure, and similar

Comments

@topepo
Copy link
Member

topepo commented Sep 27, 2021

We don't use the code directly and Ripley just changed the version requirement to >= 4.0. This means that we can't check any packages that use recipes prior to 4.0.
@juliasilge juliasilge added the upkeep maintenance, infrastructure, and similar label Sep 27, 2021
@topepo
Copy link
Member Author

topepo commented Sep 30, 2021

We'll have to avoid directly calling dimRed too since it also suggests fastICA.

topepo added a commit that referenced this issue Sep 30, 2021
@topepo
changes for #823
cc2afa3
@topepo topepo mentioned this issue Oct 7, 2021
Merged
topepo added a commit that referenced this issue Jan 13, 2022
@topepo @DavisVaughan
Remove direct usage of fastICA and dimRed (#829)
4aa5ba3 
* changes for #823

* use kernlab directly instead if dimRed

* use fastICA directly instead of dimRed

* copious skips

* add seed argument for ICA and some code refactoring

* Update R/misc.R

Co-authored-by: Davis Vaughan <davis@rstudio.com>

* uncomment example code

* rename calling function

* small new change

* roll back kpca change (bad update form main)

* updated print method for #871

* changes based on reviewer feedback

Co-authored-by: Davis Vaughan <davis@rstudio.com>
@EmilHvitfeldt EmilHvitfeldt mentioned this issue Feb 2, 2022
Closed
@EmilHvitfeldt
Copy link
Member

This PR was adequately closed by #829

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
next release 🚀 upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't link to dimRed and fastICA in documentation tidymodels/recipes
3 participants
@topepo @juliasilge @EmilHvitfeldt