Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfirst version of a check_ function #104
Conversation
|
I just checked in a bunch of changes to your PR. I made some modifications (I proposed Can you sync and re-submit? |
|
I am a bit lost in the woods with all the repos now. I can't find where exactly you made these changes. The "Files changed" and the "Commits" only show my additions. I can't find anything in the fork either. Can you point me to where to look? |
|
It is indeed quite a fuss, think we are all set now, but please do check... |
|
One more thing and I think we are there: please add a test file for the column check operation. |
|
I am learning something new about PRs every day. I did not know that when I pushed to my own github after doing a PR it was added to the PR automatically. Was not aware I already pushed the checkcolumns, it is unfinished indeed (not only tests are lacking). |
|
I think we are all set now. |
|
That warning is easy to fix so I'll get it. Also, I'll merge in another PR after this that will add a new option called Thanks! |
added
adjusted