first version of a check_ function

[EdwinTh]

added

• check_noNA
• unit tests

adjusted

• step function

[topepo]

I just checked in a bunch of changes to your PR. I made some modifications (I proposed check_missing instead of check_noNA. There were very few changes to the core of recipes. It passes all of the checks and I updated the documentation.

Can you sync and re-submit?

[EdwinTh]

I am a bit lost in the woods with all the repos now. I can't find where exactly you made these changes. The "Files changed" and the "Commits" only show my additions. I can't find anything in the fork either. Can you point me to where to look?

[topepo]

I committed them to the fork pr/104 fork on the topepo/recipes repo. Here is a list of the changes.

[I find that committing to a PR to be confusing as hell. I never know if I should commit straight to your (forked) repo or to the PR on mine.]

[EdwinTh]

It is indeed quite a fuss, think we are all set now, but please do check...

[topepo]

One more thing and I think we are there: please add a test file for the column check operation.

[EdwinTh]

I am learning something new about PRs every day. I did not know that when I pushed to my own github after doing a PR it was added to the PR automatically. Was not aware I already pushed the checkcolumns, it is unfinished indeed (not only tests are lacking).

[EdwinTh]

I think we are all set now.

[topepo]

That warning is easy to fix so I'll get it.

Also, I'll merge in another PR after this that will add a new option called skip (just as an fyi).

Thanks!

[github-actions]

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue.