Avoid map2()
when wts
aren't used
#1052
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small bug exposed by purrr 1.0.0 (the dev version). If you install the dev version of purrr and run the tests, then some of the
step_dummy_extract()
ones break because purrr now applies tidyverse recycling rules to its inputs inmap2()
andpmap()
. The error looks like:It would be great if we could get a small recipes release out to make it easier on purrr, otherwise we are going to be forced to do a release when purrr 1.0.0 eventually goes out.
The problem happens when
wts
aren't used, i.e.wts = NULL
. Thenas.double(wts)
returnsdouble()
, which isn't tidyverse recyclable againstlvls
, which is typically length >1.