Skip to content

add non-standard role bake tests for all steps #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 16, 2023

Conversation

EmilHvitfeldt
Copy link
Member

@EmilHvitfeldt EmilHvitfeldt commented May 16, 2023

This PR adds the remaining infrastructure tests and will thus close #1134 and #1130.

@EmilHvitfeldt EmilHvitfeldt requested a review from hfrick May 16, 2023 05:12
Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tests are doing what you want them to do 👍

I got hung up on the bake argument to update_role_requirements() and am wondering if I am just having a really not-sharp moment or if this is confusing to more people and should be a new issue.

Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com>
@EmilHvitfeldt EmilHvitfeldt merged commit 97e45ff into main May 16, 2023
@EmilHvitfeldt EmilHvitfeldt deleted the bake-error-non-standard branch May 16, 2023 21:46
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing infrastructure tests
2 participants