Skip to content

distances to shrunken centroids #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Aug 9, 2023
Merged

distances to shrunken centroids #1185

merged 19 commits into from
Aug 9, 2023

Conversation

topepo
Copy link
Member

@topepo topepo commented Aug 5, 2023

Finally finishing up a step that I started a while ago.

@topepo topepo marked this pull request as ready for review August 5, 2023 16:08
@EmilHvitfeldt
Copy link
Member

I took the liberty to do some changes to bring things in line with rest of the package.
among other things, this step now fully supports empty selections and has all the required infrastructure tests

Copy link
Member

@EmilHvitfeldt EmilHvitfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to make any of the variables tunable?

Also, can you expand the documentation a bit to clarify that makes the centroids shrunken

and you need to add a news bullet 📰

@EmilHvitfeldt
Copy link
Member

I'll add tunable() tests before merging

@topepo topepo merged commit 5975671 into main Aug 9, 2023
@topepo topepo deleted the nsc branch August 9, 2023 00:47
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants