-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new step_indicate_na()
#623
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
One more thing that I forgot... please add a note to the NEWS file. |
Done, should be good to go! |
@konradsemsch It seems that in the last commit f9cd575 a whole lot of unrelated files got checked in. We only want the files related to this PR checked in, not the |
I just spotted that in the R file: #' @export
tidy.step_shadow_missing <- function(x, ...) {
if (is_trained(x)) { and let me remove it, before I make the change. I think I also committed everything after loading the package locally so let me revert that. |
f9cd575
to
3c94d86
Compare
@juliasilge let me know if things are as you would expect and sorry about the previous push clutter 😉 |
Are all of the changes in for this PR? |
All from my side :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Sorry for the lag time. One minor change.
3e0ca55
to
38fcf74
Compare
Thanks! |
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org |
That's a clear start from: #617