Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add allow_rename arg to eval_select_recipes() #646

Merged
merged 11 commits into from
Mar 3, 2021
Merged

add allow_rename arg to eval_select_recipes() #646

merged 11 commits into from
Mar 3, 2021

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Feb 17, 2021

This is prep for adding a step_select().

eval_select_recipes() still returns a vector of variable names (rather than positions) as positions might differ between training and test sets. If allow_rename = TRUE, the returned vector is named with the new names.

NEWS.md Outdated Show resolved Hide resolved
NAMESPACE Show resolved Hide resolved
R/selections.R Outdated Show resolved Hide resolved
R/selections.R Outdated Show resolved Hide resolved
R/selections.R Outdated Show resolved Hide resolved
R/selections.R Show resolved Hide resolved
R/selections.R Outdated Show resolved Hide resolved
R/selections.R Outdated Show resolved Hide resolved
tests/testthat/test_rm.R Outdated Show resolved Hide resolved
hfrick and others added 5 commits March 2, 2021 15:50
Co-authored-by: Davis Vaughan <davis@rstudio.com>
Co-authored-by: Davis Vaughan <davis@rstudio.com>
Co-authored-by: Davis Vaughan <davis@rstudio.com>
@hfrick hfrick requested a review from DavisVaughan March 2, 2021 16:52
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants