Turn off parallel processing for NMF, do not load pkgs #685
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #681
This PR turns off the parallelization that NMF has on by default, which allows us to use NMF and dimRed without fully loading them as before. This solves the problem with
fit()
:Created on 2021-04-14 by the reprex package (v2.0.0)
In the future, we could consider exposing some kind of parallel option for
step_nnmf()
for folks who use it outside of our tuning infrastructure and want to run it in parallel.