Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Penalized non-negative matrix factorization #790

Merged
merged 17 commits into from
Jan 21, 2022
Merged

Penalized non-negative matrix factorization #790

merged 17 commits into from
Jan 21, 2022

Conversation

topepo
Copy link
Member

@topepo topepo commented Sep 14, 2021

Much faster than the NMF package used by step_nnmf(). Results are about the same but the new step is over 500-fold faster.

image

step_nnmf() is soft-deprecated.

Unit tests will go into the extratests repo.

Will probably wait to merge for the next release of RcppML by @zdebruine based on zdebruine/RcppML#5 (no hurry)

R/nnmf.R Outdated Show resolved Hide resolved
@zdebruine
Copy link

Will probably wait to merge for the next release of RcppML by @zdebruine based on zdebruine/RcppML#5 (no hurry)

Dense matrix support should be out sometime next week. Any data that satisfies is(A, "sparseMatrix") will be coerced to dgCMatrix (if they are not already), while all other formats will be coerced to matrix (if they are not already).

R/nnmf_sparse.R Outdated Show resolved Hide resolved
R/nnmf_sparse.R Outdated Show resolved Hide resolved
@zdebruine
Copy link

Will probably wait to merge for the next release of RcppML by @zdebruine

Dense matrix support should be out sometime next week.

RcppML v0.3.7 with dense matrix support is on GitHub and submitted to CRAN. Performance gains are modest (10-20%). A sparse matrix backend is used if is(A, "sparseMatrix") (in which case A is coerced to dgCMatrix) otherwise A is coerced to matrix and a dense backend is used.

Merge commit '84f282ddd1c1f292c8161e94dbf4b85e465d4189'

Conflicts:
	NEWS.md
	R/0_imports.R
	R/recipe.R
	R/tunable.R
	man/recipe.Rd
	man/required_pkgs.step.Rd
	man/step_mutate_at.Rd
	man/tidy.recipe.Rd
@github-actions
Copy link

github-actions bot commented Feb 5, 2022

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants