-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support empty selections in all recipe steps #813
Merged
topepo
merged 95 commits into
tidymodels:master
from
DavisVaughan:feature/empty-selection
Sep 28, 2021
Merged
Support empty selections in all recipe steps #813
topepo
merged 95 commits into
tidymodels:master
from
DavisVaughan:feature/empty-selection
Sep 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But its actually defunct so no tests are needed
Although, this will drop all columns from the recipe which causes other issues
Even though it is deprecated
Since a data frame ptype is required in the CRAN version, and `unnest()` doesn't work with a `ptype` in the CRAN version tidyverse/tidyr#1158
This was referenced Sep 28, 2021
This was referenced Sep 28, 2021
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds empty selection support to all recipe steps.
We thought that the best way to do this was to return early from each step, returning an alternate
step_empty_selection()
step, but this was problematic for a few reasons:tidy()
that step in the recipe, because the empty selection step doesn't know what columns should be therefresh = TRUE
, things got a little complicated because ideally you'd reprep with the original step, rather than the empty selection step we insertedSO, I've gone through all of the steps, ensuring that each one supports empty selection natively. Most required minimal changes, which is great. A few notes:
ellipse_check()
withenquos()
, since now empty selections are okay. This function is exported, so I also mentioned that it is sort of deprecated now in favor of supporting empty selections directly (but I didn't officially deprecate it).prep()
/bake()
, one tests the print method, and one tests thetidy()
method before and after prepping.