Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImporting `recipes` introduces many implicit dependencies #48
Comments
|
It would make sense to move |
|
@topepo would it also make sense to move |
|
I'm going to leave that one in |
At current moment, installation of
rsample(supposingtidyverseis installed) causes many packages to be installed as dependencies ofrecipes. I had 20 extra packages installed (excludingrecipesitself):List of extra packages
‘numDeriv’, ‘SQUAREM’, ‘abind’, ‘lava’, ‘kernlab’, ‘CVST’, ‘DEoptimR’, ‘magic’, ‘prodlim’, ‘DRR’, ‘robustbase’, ‘sfsmisc’, ‘geometry’, ‘ipred’, ‘dimRed’, ‘timeDate’, ‘ddalpha’, ‘gower’, ‘RcppRoll’, ‘pls’I understand the reason to facilitate using the
recipeswithrsampleby providingprepper()wrapper, but I think 20 packages not explicitly needed for core functionality is a little bit too much for one simple wrapper. Maybe it is a good idea to moverecipesback toSuggests, mention it with wrapper in vignette, and possibly addrsampleintorecipesImport(as it already has many imported packages)? Keeprsamplemore light-weight?Also current situation might be inconvenient for package authors willing to import
rsample.