-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importing recipes
introduces many implicit dependencies
#48
Comments
It would make sense to move |
@topepo would it also make sense to move |
I'm going to leave that one in |
This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue. |
At current moment, installation of
rsample
(supposingtidyverse
is installed) causes many packages to be installed as dependencies ofrecipes
. I had 20 extra packages installed (excludingrecipes
itself):List of extra packages
‘numDeriv’, ‘SQUAREM’, ‘abind’, ‘lava’, ‘kernlab’, ‘CVST’, ‘DEoptimR’, ‘magic’, ‘prodlim’, ‘DRR’, ‘robustbase’, ‘sfsmisc’, ‘geometry’, ‘ipred’, ‘dimRed’, ‘timeDate’, ‘ddalpha’, ‘gower’, ‘RcppRoll’, ‘pls’I understand the reason to facilitate using the
recipes
withrsample
by providingprepper()
wrapper, but I think 20 packages not explicitly needed for core functionality is a little bit too much for one simple wrapper. Maybe it is a good idea to moverecipes
back toSuggests
, mention it with wrapper in vignette, and possibly addrsample
intorecipes
Import
(as it already has many imported packages)? Keeprsample
more light-weight?Also current situation might be inconvenient for package authors willing to import
rsample
.The text was updated successfully, but these errors were encountered: