Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bca bug calc #179

Merged
merged 5 commits into from Sep 10, 2020
Merged

Bca bug calc #179

merged 5 commits into from Sep 10, 2020

Conversation

Dpananos
Copy link
Contributor

@Dpananos Dpananos commented Sep 7, 2020

In #177, @juliasilge mentions the bug may be because alpha is not passed to get_p0. This PR fixes that and adds additional unit tests to ensure int_bca returns appropriate confidence limits when the confidence level changes.

@Dpananos
Copy link
Contributor Author

Dpananos commented Sep 7, 2020

Hmm, not sure why tests are failing.

@Dpananos
Copy link
Contributor Author

@juliasilge Is the change in tolerance necessary? The bug didn't effect the estimates per se, it just didn't return the appropriate confidence limit intervals when an alpha other than 0.05 was passed.

@juliasilge
Copy link
Member

The tolerances are used to check both the estimates and the confidence intervals, like this:

  expect_equal(ttest_lower_conf$conf.low,
               single_bca_res_lower_conf$.lower,
               tolerance = 0.001)

With the old tolerance, these tests of the high/low confidence values all pass even when alpha does not change.

@Dpananos
Copy link
Contributor Author

Great, thanks again!

@juliasilge
Copy link
Member

Thank you so much for the PR! 🚀

@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants