Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New inheritance structure for rsplit objects and updated complement() methods #216

Merged
merged 7 commits into from
Feb 9, 2021

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Feb 4, 2021

This is to address #213 as laid out in this comment.

@hfrick hfrick marked this pull request as ready for review February 4, 2021 11:10
@topepo
Copy link
Member

topepo commented Feb 4, 2021

> revdep_check(num_workers = 20)
── INIT ────────────────────────────────────────────────────────────────── Computing revdeps ──
── INSTALL ────────────────────────────────────────────────────────────────────── 2 versions ──
Installing CRAN version of rsample
Installing DEV version of rsample
Installing 4 packages: parallelly, cpp11, dplyr, furrr
── CHECK ────────────────────────────────────────────────────────────────────── 23 packages ──
✓ ivdesc 1.0.0                           ── E: 0     | W: 0     | N: 0butcher 0.1.2                          ── E: 0     | W: 0     | N: 1gesttools 1.0.1                        ── E: 0     | W: 0     | N: 0probably 0.0.6                         ── E: 0     | W: 0     | N: 0embed 0.1.4                            ── E: 0     | W: 0     | N: 0baguette 0.1.0                         ── E: 0     | W: 0     | N: 0broom 0.7.4                            ── E: 0     | W: 0     | N: 0modeltime.resample 0.1.0               ── E: 0     | W: 0     | N: 1modeltime.ensemble 0.3.0               ── E: 0     | W: 0     | N: 1MachineShop 2.6.1                      ── E: 0     | W: 0     | N: 0finetune 0.0.1                         ── E: 0     | W: 0     | N: 1modeltime 0.4.1                        ── E: 0     | W: 0     | N: 1sitar 1.1.2                            ── E: 0     | W: 0     | N: 0stacks 0.1.0                           ── E: 0     | W: 0     | N: 2psfmi 0.7.1                            ── E: 0     | W: 0     | N: 0tfdatasets 2.2.0                       ── E: 0     | W: 0     | N: 0tidymodels 0.1.2                       ── E: 0     | W: 0     | N: 1recipes 0.1.15                         ── E: 0     | W: 0     | N: 0trendeval 0.0.1                        ── E: 0     | W: 0     | N: 0text 0.9.10                            ── E: 0     | W: 0     | N: 1tidyposterior 0.0.3                    ── E: 0     | W: 0     | N: 0tune 0.1.2                             ── E: 0     | W: 0     | N: 0timetk 2.6.1                           ── E: 0     | W: 0     | N: 2                        
OK: 23                                                                                      
BROKEN: 0
Total time: 9 min

Copy link
Member

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just

#' @importFrom rsample complement
  • and checked spatialsample with no problems ✅

This looks good to me.

Copy link
Member

@DavisVaughan DavisVaughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Is there any place where we still use add_class(at_end = TRUE)? If not, my only comment would be that you can remove at_end altogether (I can't imagine when you'd want to do this anyways)

@topepo topepo merged commit 5874b1c into master Feb 9, 2021
@topepo topepo deleted the complement-rsplit branch February 9, 2021 22:25
@hfrick
Copy link
Member Author

hfrick commented Feb 10, 2021

We don't use at_end = TRUE anywhere. Should we open a new issue?

@DavisVaughan
Copy link
Member

I think just another PR that removes it would be fine if you’d like to tackle it. Otherwise an issue is great!

hfrick added a commit that referenced this pull request Feb 10, 2021
@hfrick hfrick mentioned this pull request Feb 10, 2021
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants