Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #360 . I realized that the function was deterministic for any strata with only one group, and that it would always "short change" the last strata in the vector by giving it fewer folds as options (if
length(unique(strata)) %% v != 0
). Both of these strike me as small, but non-ideal bugs in the function; this PR changes the function so that the order of strata themselves are randomized, which I believe fixes both behaviors.Sorry to pitch a breaking change right after we merged the first version of the feature -- I had this as a shower thought this morning and realized it wouldn't be that hard to change.
I made this reprex and I don't know that it's actually helpful at all, but here's proof that this stratified sampling works:
Created on 2022-08-27 by the reprex package (v2.0.1)