Expand grouping variables for bootstrap intervals - #465
Merged
Conversation
hfrick
reviewed
Jan 22, 2024
hfrick
left a comment
Member
There was a problem hiding this comment.
Generally on board with this, go ahead with adding more unit tests 👍
topepo
added a commit
to tidymodels/tune
that referenced
this pull request
Jan 23, 2024
Member
Author
|
This is ready for final review. I've set up the |
topepo
added a commit
to tidymodels/tune
that referenced
this pull request
Jan 24, 2024
* add maybe_choose_eval_time * re-write survival bits * update/fix tests * nocov * added additional test * version bump * changes based on reviewer feedback * updates to work with tidymodels/rsample#465 * update snapshots --------- Co-authored-by: ‘topepo’ <‘mxkuhn@gmail.com’>
Contributor
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some tune internals, it would be helpful to be able to make intervals for an extended set of column columns (s opposed to just
terms). See tidymodels/tune#818.These changes are a proposal to expand things to include columns starting with a period. We can discuss it, and I can create more unit tests if we're good with this.
Here's an example:
library(tidymodels)Created on 2024-01-19 with reprex v2.0.2