Skip to content

Uses cli_abort in R/caret.R#517

Merged
hfrick merged 5 commits into
tidymodels:mainfrom
Dpananos:cli_caret
Sep 12, 2024
Merged

Uses cli_abort in R/caret.R#517
hfrick merged 5 commits into
tidymodels:mainfrom
Dpananos:cli_caret

Conversation

@Dpananos

@Dpananos Dpananos commented Aug 15, 2024

Copy link
Copy Markdown
Contributor

closes #505

@Dpananos

Copy link
Copy Markdown
Contributor Author

Need to format with {.arg} as mentioned here #518 (comment)

@EmilHvitfeldt EmilHvitfeldt changed the title Uses cli_abbort in R/caret.R Uses cli_abort in R/caret.R Aug 15, 2024
@Dpananos

Copy link
Copy Markdown
Contributor Author

This should be ready for review

@hfrick

hfrick commented Aug 23, 2024

Copy link
Copy Markdown
Member

@Dpananos Thanks a bunch for the multiple PRs! I'm just dropping in quickly to say that I'm OOO until the week after next but will get to this after my return.

@hfrick
hfrick merged commit e489196 into tidymodels:main Sep 12, 2024
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions Bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use cli errors for R/caret.R

2 participants