rsample fix for rlang::abort as cli_abort for 506 #523
Merged
Conversation
…tion message which needed to be changed to a vector and there is one class message where the semantics had to be adjusted. Fixes tidymodels#506
PriKalra
commented
Aug 15, 2024
hfrick
reviewed
Aug 15, 2024
hfrick
left a comment
hfrick
left a comment
Member
There was a problem hiding this comment.
Thank you for tackling this! Could you also run the tests and update snapshots accordingly? If you'd like some help doing that, come see me!
Contributor
Author
|
I have done the tests, included the feedback and run a rCMD check. |
Contributor
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaced all the rlang::abort to cli_abort without using cli::
closes #506 and closes #508