Skip to content

Mark rolling_origin() as superseded#524

Merged
hfrick merged 7 commits into
tidymodels:mainfrom
nmercadeb:deprecate_rolling_origin
Sep 4, 2024
Merged

Mark rolling_origin() as superseded#524
hfrick merged 7 commits into
tidymodels:mainfrom
nmercadeb:deprecate_rolling_origin

Conversation

@nmercadeb
Copy link
Copy Markdown
Contributor

Closes #448

Comment thread vignettes/Common_Patterns.Rmd
nmercadeb and others added 2 commits August 15, 2024 14:26
Copy link
Copy Markdown
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Could you also add the corresponding badge to the documentation as laid out here: https://lifecycle.r-lib.org/articles/communicate.html#supersede-a-function

@hfrick
Copy link
Copy Markdown
Member

hfrick commented Aug 23, 2024

@nmercadeb Thank you for the edits! I'm just dropping in quickly to say that I'm OOO until the week after next but will get to this after my return.

@hfrick hfrick changed the title deprecate rolling_origin Mark rolling_origin() as superseded Sep 4, 2024
@hfrick hfrick merged commit 5c8d38e into tidymodels:main Sep 4, 2024
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions Bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mark rolling_origin() as superseded

3 participants