Skip to content

Rsample cli errors update for #510#531

Merged
hfrick merged 4 commits into
tidymodels:mainfrom
PriKalra:cliErrorRegIntervalandPermutationUpdate510
Sep 10, 2024
Merged

Rsample cli errors update for #510#531
hfrick merged 4 commits into
tidymodels:mainfrom
PriKalra:cliErrorRegIntervalandPermutationUpdate510

Conversation

@PriKalra

Copy link
Copy Markdown
Contributor

Have added some creative ways of throwing cli errors recently. Thank you for looking into the code and suggesting- alongside the patience! :D
Let me know if these changes make sense in the big picture!

fixed #510

@hfrick

hfrick commented Sep 10, 2024

Copy link
Copy Markdown
Member

Thanks so much! You've clearly learned more styling options since the previous PR, well done! I've generally "toned it down" a little bit to keep it more like the rest of error messages in rsample and elsewhere. The little arrow produced by ">" is nice detail though that I've kept!

@hfrick hfrick merged commit 6e2721a into tidymodels:main Sep 10, 2024
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions Bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use cli errors in R/permutations.R, R/reg_intervals.R

2 participants