Cli errors for validation_set and vfold. - #532
Conversation
|
@PriKalra The snapshots capture how the error is supposed to look and the snapshot tests compare the current version of the error to those snapshots. So when you change how an error looks, it doesn't match the snapshot anymore and the corresponding test fails. If the change is what you want, you can update the reference, the snapshot. This part of the output tells you both how to review the changes to decide on whether or not they were want you intended and how to update the snapshot to the new version ("accept the changes"). Does this clear things up or did I misinterpet your comment? Nothing further needed, thank so much for all the changes! 🙏 |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
fixes #514
I have changed some styling with Cli abort. there are 5 failed tests the are arising from Validation_set and vfold. I ran the cli_abort in a local context and they throw the errors correctly- so I think there is a clash with the way tests are written?
Let me know if there are further improvements in the errors required by me: