inner_split() methods for initial validation splits#577
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds support for inner splits on initial validation variants by implementing new S3 methods, updating argument extraction, documentation, and tests.
- Introduced
inner_split.initial_validation_split,inner_split.group_initial_validation_split, andinner_split.initial_validation_time_splitin R/inner_split.R - Adjusted argument extraction in R/misc.R to handle validation splits
- Added aliases/method entries in man/inner_split.Rd and NAMESPACE, plus corresponding tests in tests/testthat/test-inner_split.R
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/testthat/test-inner_split.R | Added tests for initial validation, grouped validation, and time-based validation inner splits |
| man/inner_split.Rd | Added aliases and \method entries for the new inner split variants |
| R/misc.R | Special-cased val_att extraction for validation splits in split_unnamed |
| R/inner_split.R | Implemented three new inner_split.* methods for validation splits |
| NAMESPACE | Registered new S3 methods for validation inner splits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #572
The inner split objects here don't inherit all the classes from the original object because inner splits are 2-way splits while the original objects are 3-way splits.