Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't need rsample::: in tests #73

Merged
merged 1 commit into from Jan 6, 2019

Conversation

Projects
None yet
3 participants
@krlmlr
Copy link
Contributor

commented Dec 20, 2018

because all internal functions are available in the environment in which the tests are run.

Also changes one instance of as.tibble() to as_tibble().

@codecov-io

This comment has been minimized.

Copy link

commented Dec 20, 2018

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   84.03%   84.03%           
=======================================
  Files          20       20           
  Lines         739      739           
=======================================
  Hits          621      621           
  Misses        118      118

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60fa7ec...98bffb3. Read the comment docs.

@topepo topepo merged commit c1c5f7d into tidymodels:master Jan 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.