Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the description of under_ratio in step_downsample() correct? #110

Closed
mattwarkentin opened this issue Dec 14, 2022 · 2 comments · Fixed by #146
Closed

Is the description of under_ratio in step_downsample() correct? #110

mattwarkentin opened this issue Dec 14, 2022 · 2 comments · Fixed by #146

Comments

@mattwarkentin
Copy link

mattwarkentin commented Dec 14, 2022

Hi,

This is the description for under_ratio in step_downsample():

A numeric value for the ratio of the minority-to-majority frequencies. The default value (1) means that all other levels are sampled down to have the same frequency as the least occurring level. A value of 2 would mean that the majority levels will have (at most) (approximately) twice as many rows than the minority level.

It seems like based on the line A value of 2 would mean that the majority levels will have (at most) (approximately) twice as many rows than the minority level that under_ratio is the majority-to-minority frequency, or am I misunderstanding?

Thanks for the clarification.

@EmilHvitfeldt
Copy link
Member

I think you might be right, thank you!

Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants