metrics with a target value of zero

@DavisVaughan

show_best() and others have code that looks like:

  if (maximize) {
    summary_res <- summary_res %>% dplyr::arrange(dplyr::desc(mean))
  } else {
    summary_res <- summary_res %>% dplyr::arrange(mean)
  }

This should be adjusted for cases when there is a target value.

Perhaps we can use maximize = FALSE and arrange by (abs(mean - target)).

@DavisVaughan

Currently all yardstick metrics optimize with one of maximize/minimize/zero. I havent run across any that have an arbitrary target, but I guess it is possible.

It might be worth leaving the direction variable as a character string, rather than converting it to a logical maximize variable. Then you'd just handle the 3 cases by expanding the if statement you have above.

if (direction == "maximize") {

} else if (direction == "minimize") {

} else if (direction == "zero") {

} else {
  abort("Internal error: Unknown direction")
}

If we run into metrics later on that have some arbitrary target value, then we'd have to reconsider how this works in both yardstick and tune (currently in yardstick direction is a character string, but it would probably have to become a numeric value for arbitrary targets)

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

Navigation Menu

Repository navigation

metrics with a target value of zero #243

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

metrics with a target value of zero #243

Description

Activity

DavisVaughan commented on Jul 6, 2020

github-actions commented on Nov 30, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions