Skip to content

Parallel seeds#1033

Merged
topepo merged 8 commits into
melodie-switchfrom
parallel-seeds
Jul 7, 2025
Merged

Parallel seeds#1033
topepo merged 8 commits into
melodie-switchfrom
parallel-seeds

Conversation

@topepo

@topepo topepo commented Jul 3, 2025

Copy link
Copy Markdown
Member

We now generate L'Ecuyer-CMRG seeds that are matched to resamples. These are set for sequential and parallel execution.

Comment thread R/parallel_new.R
future.stdout = TRUE,
future.seed = TRUE, # TODO <- this line may change
future.packages = quote(load_pkgs)
future.seed = NULL

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are setting our own so don't yell at me bro 😄

Comment thread R/parallel_new.R Outdated
@topepo
topepo requested a review from simonpcouch July 3, 2025 21:01
Comment thread R/loop_over_all_stages.R

if (static$control$save_pred) {
return_tbl$.predictions <- list(add_configs(pred_reserve, static, config_tbl))
return_tbl$.predictions <- list(add_configs(

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤢

@simonpcouch simonpcouch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heck yeah!!

Comment thread NEWS.md
Comment thread R/loop_over_all_stages.R Outdated
Comment thread R/loop_over_all_stages.R Outdated
Comment thread R/parallel_new.R Outdated
Comment thread tests/testthat/test-parallel.R
})


test_that("same results using mirai", {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so awesome

topepo and others added 2 commits July 7, 2025 16:40
Co-authored-by: Simon P. Couch <simonpatrickcouch@gmail.com>
@topepo
topepo marked this pull request as ready for review July 7, 2025 21:31
@topepo
topepo merged commit a1cda00 into melodie-switch Jul 7, 2025
1 check failed
@topepo
topepo deleted the parallel-seeds branch July 7, 2025 21:32
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions Bot locked and limited conversation to collaborators Jul 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants