-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add collect_*()
function for extracted objects
#579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the name!
I think it would be helpful if the error said that there was nothing to collect, rather than that collection failed in general (there could be so many reasons for this). This is also in the spirit of what collect_predictions()
does.
collect_notes()
returns location
while collect_extracts()
return .config
. They look similar; are they the same information just displayed differently?
Do we still want a collect_glmnet_coefficients()
? If so, then let's open a new issue for it so that this idea doesn't get lost when closing #409
Agreed! Addressed in 265e311. :)
Similar information, though my understanding is that
You got it! #582 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 Nice!
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Closes #409.🦃 I opted to call this helper
collect_extracts()
rather than the suggested name in the issue for consistency with othercollect_*()
function names, but am open to discussion here.Created on 2022-11-17 with reprex v2.0.2
Interactively in the IDE, the error message with
collect_extracts(res_nothing)
formatscontrol object
as a hyperlink to those docs, rather than printing the link.