Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tidyr_new_interface() check #634

Merged
merged 1 commit into from
Mar 13, 2023
Merged

remove tidyr_new_interface() check #634

merged 1 commit into from
Mar 13, 2023

Conversation

simonpcouch
Copy link
Contributor

Cutting out complexity is nice! But also, turns out packageVersion() is a slow-poke.🦥

With main dev:

library(tidymodels)

bench::mark(
  fit = fit_resamples(linear_reg(), mpg ~ ., bootstraps(mtcars))
)
#> # A tibble: 1 × 6
#>   expression        min    median `itr/sec` mem_alloc `gc/sec`
#>   <bch:expr>   <bch:tm>  <bch:tm>     <dbl> <bch:byt>    <dbl>
#> 1 fit             1.11s     1.11s     0.907    30.5MB     7.25

With this PR:

#> # A tibble: 1 × 6
#>   expression      min   median `itr/sec` mem_alloc `gc/sec`
#>   <bch:expr> <bch:tm> <bch:tm>     <dbl> <bch:byt>    <dbl>
#> 1 fit           1.03s    1.03s     0.936    29.4MB     8.42

Created on 2023-03-12 with reprex v2.0.2

The minimum version for tidyr in DESCRIPTION has been bumped since these changes were added anyway, so this helper would always return TRUE:

tidyr (>= 1.2.0),

@simonpcouch simonpcouch requested a review from hfrick March 13, 2023 01:50
Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎈

@simonpcouch simonpcouch merged commit 921ca15 into main Mar 13, 2023
@simonpcouch simonpcouch deleted the tidyr-new-interface branch March 13, 2023 17:43
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants