Skip to content

speed up predict_model() #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2023
Merged

speed up predict_model() #636

merged 1 commit into from
Mar 13, 2023

Conversation

simonpcouch
Copy link
Contributor

Rewrites dplyr in predict_model() to use vctrs and tibble. :) With main dev tune:

library(tidymodels)

bench::mark(
  fit =  fit_resamples(linear_reg(), mpg ~ ., bootstraps(mtcars)),
  tune = tune_grid(boost_tree(mode = "regression", trees = tune()), mpg ~ ., bootstraps(mtcars)),
  check = FALSE
)
#> # A tibble: 2 × 6
#>   expression      min   median `itr/sec` mem_alloc `gc/sec`
#>   <bch:expr> <bch:tm> <bch:tm>     <dbl> <bch:byt>    <dbl>
#> 1 fit           1.11s    1.11s     0.903      27MB     8.13
#> 2 tune          5.28s    5.28s     0.189     394MB     6.25

With this PR:

#> # A tibble: 2 × 6
#>   expression      min   median `itr/sec` mem_alloc `gc/sec`
#>   <bch:expr> <bch:tm> <bch:tm>     <dbl> <bch:byt>    <dbl>
#> 1 fit           1.05s    1.05s     0.948    26.9MB     8.53
#> 2 tune          5.17s    5.17s     0.193     403MB     5.61

Created on 2023-03-12 with reprex v2.0.2

Copy link
Member

@EmilHvitfeldt EmilHvitfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking clean!

@simonpcouch simonpcouch merged commit 4bdbde1 into main Mar 13, 2023
@simonpcouch simonpcouch deleted the predict-model-speedup branch March 13, 2023 17:43
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants