Skip to content

Use CLI errors #241

@EmilHvitfeldt

Description

@EmilHvitfeldt

Ref: tidymodels/rsample#457

Most or all errors thrown in this package are made via rlang::abort(). We are transitioning to cli::cli_abort() to make use of the richer styling options for errors via cli (which calls rlang under the hood).

The package itself uses abort() and warn() fairly straightforwardly so I don't think this will be challenging.

All warn() calls are in remove_* functions, doing the same thing.

took a look and found https://github.com/tidymodels/workflows/blob/main/R/broom.R#L38 which won't be reached because of arg_match()

This issue is deliberately not a tidy-dev-day issue because {workflows} imports dev versions of {hardhat}, {parsnip}, {recipes}, and {rsample}. And imports the pre-CRAN package {tailor}

Metadata

Metadata

Assignees

No one assigned

    Labels

    featurea feature request or enhancement

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions