predict.workflow() fails if a recipe step affects an outcome #31

Activity

1. DavisVaughan commented on Apr 3, 2020

   

   DavisVaughan

   on Apr 3, 2020

   Member

   More actions

   Adding outcomes = TRUE wouldn't fix this, as that would require that you always have the outcomes available at prediction time, which you generally don't unless you are doing resampling.

   This problem is outlined in the hardhat vignette https://tidymodels.github.io/hardhat/articles/forge.html#a-note-on-recipes

   Essentially you need to skip the recipe steps that specifically affect the outcome, so they aren't run at bake time. This keeps recipes from trying to look for an outcome that won't be there.

   suppressPackageStartupMessages({
     library("workflows")
     library("parsnip")
     library("recipes")
   })
   
   training <- mtcars[1:20,]
   testing <- mtcars[21:32,]
   
   model <- linear_reg()
   model <- set_engine(model, "lm")
   
   workflow <- workflow()
   workflow <- add_model(workflow, model)
   
   recipe  <- recipe(mpg ~ cyl + disp, training)
   recipe2 <- step_log(recipe, all_outcomes(), skip = TRUE)
   
   workflow2 <- add_recipe(workflow, recipe2)
   
   fit_workflow2 <- fit(workflow2, training)
   
   predict(fit_workflow2, testing)
   #> # A tibble: 12 x 1
   #>    .pred
   #>    <dbl>
   #>  1  3.25
   #>  2  2.72
   #>  3  2.75
   #>  4  2.67
   #>  5  2.59
   #>  6  3.32
   #>  7  3.25
   #>  8  3.30
   #>  9  2.67
   #> 10  3.11
   #> 11  2.75
   #> 12  3.25

   ^{Created on 2020-04-03 by the reprex package (v0.3.0)}

   👍React with 👍1Reacted by Luca Zavarella
2. DavisVaughan

   closed this as completedon Apr 3, 2020
3. hplieninger commented on Apr 3, 2020

   

   hplieninger

   on Apr 3, 2020

   Author

   More actions

   I see, thanks for the quick and informative answer. In hindsight, and after checking the respective recipes vignette again, this is clear.
4. github-actions commented on Mar 6, 2021

   

   github-actionsbot

   on Mar 6, 2021

   More actions

   This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.
5. github-actions

   locked and limited conversation to collaborators on Mar 6, 2021