Implement add_case_weights() and friends#118
Merged
DavisVaughan merged 22 commits intomainfrom Apr 25, 2022
Merged
Conversation
DavisVaughan
force-pushed
the
feature/case-weights
branch
from
e07b3ff to
262ce25
Compare
This comment was marked as resolved.
This comment was marked as resolved.
DavisVaughan
added a commit
that referenced
this pull request
Apr 22, 2022
Since the recipe can potentially change the number of rows, meaning that our retained case weights vector could get out of sync. Handles the issue noted in #118 (comment)
With suboptimal rlang call, but not sure we can improve that much right now
This is slightly better for type stability
Rather than overwriting the `$mold` slot directly. This allows the internal validation bits to actually run.
Skipping a prediction time test for case weights + recipes for now. Currently hardhat requires that ALL roles are present at prediction time, rather than just outcome/predictor roles, which will be a better default.
Since the recipe can potentially change the number of rows, meaning that our retained case weights vector could get out of sync. Handles the issue noted in #118 (comment)
DavisVaughan
force-pushed
the
feature/case-weights
branch
from
d4578f8 to
e7672ef
Compare
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.