test that sparse matrices work with fit()#258
Merged
Conversation
EmilHvitfeldt
commented
Sep 20, 2024
Comment on lines
+81
to
+82
| # We expect 1 materialization - the outcome | ||
| expect_snapshot(wf_fit <- fit(wf_spec, hotel_data)) |
Member
Author
There was a problem hiding this comment.
so we can't avoid materialization completely. Because the outcome is sparse. So instead we throw a message when materialization happens. And we just manually have to check that it only shows up once
Member
Author
There was a problem hiding this comment.
which is embedded in the snapshot
4 tasks
simonpcouch
approved these changes
Sep 24, 2024
Co-authored-by: Simon P. Couch <simonpatrickcouch@gmail.com>
Co-authored-by: Simon P. Couch <simonpatrickcouch@gmail.com>
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #239
early in
fit.workflow(), turn data into sparse tibble if data is sparse matrix.