update should_use_sparsity() to work with lightgbm - #290
Merged
Merged
Conversation
hfrick
approved these changes
Aug 5, 2025
hfrick
left a comment
hfrick
left a comment
Member
There was a problem hiding this comment.
Happy to merge this (yay sparsity!) but wanted to check in with you on one thing: The NEWS entry just refers to lightgbm, but also some of the coefficients for the baseline and other engines change. That's what you want, right?
Member
Author
|
I'm not loving that the coefficients are different for other models, but that is what happens when we rerun the simulation. So i think it is fine |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
done in combination with tidymodels/benchmark-sparsity-threshold#4