Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible duplication of vignette #236

Closed
hfrick opened this issue Sep 17, 2021 · 4 comments
Closed

Possible duplication of vignette #236

hfrick opened this issue Sep 17, 2021 · 4 comments

Comments

@hfrick
Copy link
Member

hfrick commented Sep 17, 2021

I noticed that the yardstick vignette Custom metric looks very similar to the Custom performance metrics article on tidymodels.org . In other packages like parsnip and recipes, the pkgdown site for the individual package links to the article on tidymodels.org instead of keeping the same/similar content in two places.

Is it intentional that these two articles exist in separate places or should the pkgdown site just link out to tidymodels.org?

@DavisVaughan
Copy link
Member

Hmm, I would have thought that since this article only used yardstick (as opposed to using many tidymodels packages), it would have just been a yardstick vignette and not on the tidymodels.org site. Creating a new metric is also a somewhat specialized thing that I'd hope most users won't have to do

@juliasilge
Copy link
Member

Pretty much all the content at /learn/develop is a bit specialized and not something most users will have to do, but people who are extending tidymodels (not necessarily in packages but just with internal tooling) have said it is helpful to have the long form instructions about how to make a new recipe, parsnip model, yardstick metric, etc all in one place vs. having to look around at different pkgdown sites. Making custom metrics seems pretty common compared to making, say, a new parsnip model (like for an internal KPI or similar).

It's not the end of the world to maintain two articles but I'd say the tidymodels.org page is probably the higher priority (more people have linked to it or mentioned it); we might consider whether maintaining both is the right call.

@DavisVaughan
Copy link
Member

Okay that sounds fine. We can:

  • Make sure the tidyverse.org post is up to date with any changes that may have happened here
  • Delete the yardstick article, instead linking to tidyverse.org

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants