Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roc_auc() with hand-till requires that we pull by name, when we should do by position #86

Closed
DavisVaughan opened this issue Feb 7, 2019 · 2 comments · Fixed by #90
Closed

roc_auc() with hand-till requires that we pull by name, when we should do by position #86

DavisVaughan opened this issue Feb 7, 2019 · 2 comments · Fixed by #90

Comments

@DavisVaughan
Copy link
Member

This was fixed with all of the multiclass metrics, but hand-till is slightly different and it was not fixed there.
@DavisVaughan
Copy link
Member Author

https://github.com/tidymodels/yardstick/blob/master/R/prob-roc_auc.R#L193

@DavisVaughan DavisVaughan mentioned this issue Mar 8, 2019
Merged
DavisVaughan added a commit that referenced this issue Mar 8, 2019
@DavisVaughan
Fix roc_auc() hand till when col names don't match levels (#90)
d9bfa87 
* Closes #86 
* Force column names of `estimate` to match `levels(truth)`
* Add a test to mimic parsnip output
* NEWS
@github-actions
Copy link

github-actions bot commented Mar 7, 2021

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 86 tidymodels/yardstick
1 participant
@DavisVaughan