Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: SAP HANA #233

Closed
javierluraschi opened this issue Feb 4, 2019 · 5 comments · Fixed by #504
Closed

Backend: SAP HANA #233

javierluraschi opened this issue Feb 4, 2019 · 5 comments · Fixed by #504
Labels
backend 🕺 feature a feature request or enhancement
Milestone

Comments

@javierluraschi
Copy link
Contributor

While SAP HANA has been reported to work with dbplyr, there is functionality that is unsupported and will need special translations in dbplyr, for instance:

  • dbplyr::compute() and dbplyr::copy_to() require temp tables to be prefixed with #.
  • No support for logical types since BIT require a different mapping.

In order to test and resolve those issues, a SAP HANA cloud instance can be started in Amazon thorough SAP HANA on AWS and Azure SAP HANA.

The ODBC drivers can be downloaded as follows:

CC: @edgararuiz

@hadley
Copy link
Member

hadley commented Feb 4, 2019

Do we have a specific need/request for SAP HANA support?

@hadley hadley added feature a feature request or enhancement verb trans 🤖 Translation of dplyr verbs to SQL labels Feb 4, 2019
@hadley hadley changed the title Support for SAP HANA Add SAP HANA backend Feb 6, 2019
@hadley hadley changed the title Add SAP HANA backend Backend: SAP HANA Feb 6, 2019
@xstodeepak
Copy link

It would be awesome for the entire corporate community for which SAP HANA is the backbone of entire reporting. Around 90-95% of the organizations use SAP HANA for all of their reporting needs.

Having dbplyr support for SAP HANA would immensely benefit the developer/data scientist community, since, HANA database has complex table structures and lack of BI Infrastructure with SAP. Getting BI projects done by IT teams is really a pain and having dbplyr support for SAP Hana will ease this pain to a very large extent.

Hence, requesting SAP HANA database support by dbplyr.

@joshmuncke
Copy link

+1 request for HANA dbplyr translation.

We’re pretty organisationally locked into HANA as an RDBMS and dbplyr has been a big unlock for our teams.

Being able to make full use of dbplyr functionality and particularly upload/temp table creation would be huge for us.

@hadley hadley added backend 🕺 and removed verb trans 🤖 Translation of dplyr verbs to SQL labels Sep 17, 2020
@hadley hadley added this to the 2.0.0 milestone Sep 22, 2020
@hadley
Copy link
Member

hadley commented Sep 27, 2020

hadley added a commit that referenced this issue Sep 27, 2020
hadley added a commit that referenced this issue Sep 28, 2020
@hadley
Copy link
Member

hadley commented Sep 28, 2020

The basics are now in dev dplyr + r-dbi/odbc#396. This seems to mostly work for me locally. The mac hana ODBC driver seems to be extremely crash prone but I'm pretty sure that's unrelated to odbc/dbplyr. However, it makes for an extremely frustrating development experience, so I've put in as much time into this as I'm willing to. Hopefully there's enough there that other folks in the community can add on as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend 🕺 feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants