New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weird dbplyr error when the dev version of dplyr is installed #448
Comments
Much simpler reprex: # Load package
RMariaDB::MariaDB()
#> <MariaDBDriver>
my_db <- dbplyr::simulate_dbi("MariaDBConnection")
dplyr::sql_escape_ident(my_db, "accounts")
#> <SQL> `accounts`
dplyr::sql_escape_ident(my_db, dbplyr::as.sql("accounts"))
#> <SQL> "accounts"
DBI::dbQuoteIdentifier(my_db, dbplyr::as.sql("accounts"))
#> <SQL> "accounts" Created on 2020-05-11 by the reprex package (v0.3.0) Session infodevtools::session_info()
#> ─ Session info ───────────────────────────────────────────────────────────────
#> setting value
#> version R version 3.6.3 (2020-02-29)
#> os Ubuntu 18.04.4 LTS
#> system x86_64, linux-gnu
#> ui X11
#> language (EN)
#> collate en_US.UTF-8
#> ctype en_US.UTF-8
#> tz Europe/Zurich
#> date 2020-05-11
#>
#> ─ Packages ───────────────────────────────────────────────────────────────────
#> package * version date lib source
#> assertthat 0.2.1 2019-03-21 [2] CRAN (R 3.6.3)
#> backports 1.1.6 2020-04-05 [2] CRAN (R 3.6.3)
#> bit 1.1-15.2 2020-02-10 [2] CRAN (R 3.6.3)
#> bit64 0.9-7 2017-05-08 [2] CRAN (R 3.6.3)
#> callr 3.4.3 2020-03-28 [2] CRAN (R 3.6.3)
#> cli 2.0.2 2020-02-28 [2] CRAN (R 3.6.3)
#> crayon 1.3.4 2017-09-16 [2] CRAN (R 3.6.3)
#> DBI 1.1.0 2019-12-15 [1] local
#> dbplyr 1.4.3 2020-04-19 [2] CRAN (R 3.6.3)
#> desc 1.2.0 2018-05-01 [2] CRAN (R 3.6.3)
#> devtools 2.3.0.9000 2020-05-05 [1] local
#> digest 0.6.25 2020-02-23 [2] CRAN (R 3.6.3)
#> dplyr 0.8.99.9002 2020-05-09 [1] local
#> ellipsis 0.3.0 2019-09-20 [2] CRAN (R 3.6.3)
#> evaluate 0.14 2019-05-28 [2] CRAN (R 3.6.3)
#> fansi 0.4.1 2020-01-12 [1] Github (brodieG/fansi@7ccb892)
#> fs 1.4.1 2020-04-04 [2] CRAN (R 3.6.3)
#> generics 0.0.2 2018-11-29 [2] CRAN (R 3.6.3)
#> glue 1.4.0 2020-04-03 [2] CRAN (R 3.6.3)
#> highr 0.8 2019-03-20 [2] CRAN (R 3.6.3)
#> hms 0.5.3 2020-01-08 [2] CRAN (R 3.6.3)
#> htmltools 0.4.0.9002 2020-02-13 [1] Github (rstudio/htmltools@e07546c)
#> knitr 1.28 2020-02-06 [2] CRAN (R 3.6.3)
#> lifecycle 0.2.0 2020-03-06 [2] CRAN (R 3.6.3)
#> magrittr 1.5.0.9000 2020-05-04 [1] Github (tidyverse/magrittr@93cdc9a)
#> memoise 1.1.0.9000 2020-03-06 [1] Github (hadley/memoise@58d3972)
#> pillar 1.4.4 2020-05-05 [2] CRAN (R 3.6.3)
#> pkgbuild 1.0.8 2020-05-07 [2] CRAN (R 3.6.3)
#> pkgconfig 2.0.3 2019-09-22 [2] CRAN (R 3.6.3)
#> pkgload 1.0.2 2018-10-29 [2] CRAN (R 3.6.3)
#> prettyunits 1.1.1 2020-01-24 [1] CRAN (R 3.6.2)
#> processx 3.4.2 2020-02-09 [2] CRAN (R 3.6.3)
#> ps 1.3.3 2020-05-08 [2] CRAN (R 3.6.3)
#> purrr 0.3.4 2020-04-17 [2] CRAN (R 3.6.3)
#> R6 2.4.1 2019-11-12 [2] CRAN (R 3.6.3)
#> Rcpp 1.0.4.6 2020-04-09 [2] CRAN (R 3.6.3)
#> remotes 2.1.1.9000 2020-03-30 [1] local
#> reprex 0.3.0 2020-03-18 [1] local
#> rlang 0.4.6.9000 2020-05-09 [1] Github (r-lib/rlang@4bea875)
#> RMariaDB 1.0.8 2019-12-18 [2] CRAN (R 3.6.3)
#> rmarkdown 2.1 2020-01-20 [2] CRAN (R 3.6.3)
#> rprojroot 1.3.2.9000 2019-11-30 [1] Github (r-lib/rprojroot@4e4f70c)
#> sessioninfo 1.1.1 2018-11-05 [2] CRAN (R 3.6.3)
#> stringi 1.4.6 2020-02-17 [2] CRAN (R 3.6.3)
#> stringr 1.4.0 2019-02-10 [2] CRAN (R 3.6.3)
#> testthat 2.3.2.9000 2020-04-29 [1] local
#> tibble 3.0.1.9000 2020-04-29 [1] local
#> tidyselect 1.0.0.9000 2020-02-06 [1] local
#> usethis 1.6.1.9000 2020-05-10 [1] local
#> vctrs 0.3.0 2020-05-09 [1] Github (r-lib/vctrs@5b71d88)
#> withr 2.2.0 2020-04-20 [2] CRAN (R 3.6.3)
#> xfun 0.13 2020-04-13 [2] CRAN (R 3.6.3)
#> yaml 2.2.1 2020-02-01 [1] CRAN (R 3.6.2)
#>
#> [1] /home/kirill/R-dev
#> [2] /home/kirill/R/x86_64-pc-linux-gnu-library/3.6
#> [3] /usr/local/lib/R/site-library
#> [4] /usr/lib/R/site-library
#> [5] /usr/lib/R/library CRAN version# Load package
RMariaDB::MariaDB()
#> <MariaDBDriver>
my_db <- dbplyr::simulate_dbi("MariaDBConnection")
dplyr::sql_escape_ident(my_db, "accounts")
#> <SQL> `accounts`
dplyr::sql_escape_ident(my_db, dbplyr::as.sql("accounts"))
#> <SQL> `accounts`
DBI::dbQuoteIdentifier(my_db, dbplyr::as.sql("accounts"))
#> <SQL> `accounts` Created on 2020-05-11 by the reprex package (v0.3.0) Session infodevtools::session_info()
#> ─ Session info ───────────────────────────────────────────────────────────────
#> setting value
#> version R version 3.6.3 (2020-02-29)
#> os Ubuntu 18.04.4 LTS
#> system x86_64, linux-gnu
#> ui X11
#> language (EN)
#> collate en_US.UTF-8
#> ctype en_US.UTF-8
#> tz Europe/Zurich
#> date 2020-05-11
#>
#> ─ Packages ───────────────────────────────────────────────────────────────────
#> package * version date lib source
#> assertthat 0.2.1 2019-03-21 [1] CRAN (R 3.6.3)
#> backports 1.1.6 2020-04-05 [1] CRAN (R 3.6.3)
#> bit 1.1-15.2 2020-02-10 [1] CRAN (R 3.6.3)
#> bit64 0.9-7 2017-05-08 [1] CRAN (R 3.6.3)
#> callr 3.4.3 2020-03-28 [1] CRAN (R 3.6.3)
#> cli 2.0.2 2020-02-28 [1] CRAN (R 3.6.3)
#> crayon 1.3.4 2017-09-16 [1] CRAN (R 3.6.3)
#> DBI 1.1.0 2019-12-15 [1] CRAN (R 3.6.3)
#> dbplyr 1.4.3 2020-04-19 [1] CRAN (R 3.6.3)
#> desc 1.2.0 2018-05-01 [1] CRAN (R 3.6.3)
#> devtools 2.3.0 2020-04-10 [1] CRAN (R 3.6.3)
#> digest 0.6.25 2020-02-23 [1] CRAN (R 3.6.3)
#> dplyr 0.8.5 2020-03-07 [1] CRAN (R 3.6.3)
#> ellipsis 0.3.0 2019-09-20 [1] CRAN (R 3.6.3)
#> evaluate 0.14 2019-05-28 [1] CRAN (R 3.6.3)
#> fansi 0.4.1 2020-01-08 [1] CRAN (R 3.6.3)
#> fs 1.4.1 2020-04-04 [1] CRAN (R 3.6.3)
#> glue 1.4.0 2020-04-03 [1] CRAN (R 3.6.3)
#> highr 0.8 2019-03-20 [1] CRAN (R 3.6.3)
#> hms 0.5.3 2020-01-08 [1] CRAN (R 3.6.3)
#> htmltools 0.4.0 2019-10-04 [1] CRAN (R 3.6.3)
#> knitr 1.28 2020-02-06 [1] CRAN (R 3.6.3)
#> lifecycle 0.2.0 2020-03-06 [1] CRAN (R 3.6.3)
#> magrittr 1.5 2014-11-22 [1] CRAN (R 3.6.3)
#> memoise 1.1.0 2017-04-21 [1] CRAN (R 3.6.3)
#> pillar 1.4.4 2020-05-05 [1] CRAN (R 3.6.3)
#> pkgbuild 1.0.8 2020-05-07 [1] CRAN (R 3.6.3)
#> pkgconfig 2.0.3 2019-09-22 [1] CRAN (R 3.6.3)
#> pkgload 1.0.2 2018-10-29 [1] CRAN (R 3.6.3)
#> prettyunits 1.1.1 2020-01-24 [1] CRAN (R 3.6.3)
#> processx 3.4.2 2020-02-09 [1] CRAN (R 3.6.3)
#> ps 1.3.3 2020-05-08 [1] CRAN (R 3.6.3)
#> purrr 0.3.4 2020-04-17 [1] CRAN (R 3.6.3)
#> R6 2.4.1 2019-11-12 [1] CRAN (R 3.6.3)
#> Rcpp 1.0.4.6 2020-04-09 [1] CRAN (R 3.6.3)
#> remotes 2.1.1 2020-02-15 [1] CRAN (R 3.6.3)
#> reprex 0.3.0 2019-05-16 [1] CRAN (R 3.6.3)
#> rlang 0.4.6 2020-05-02 [1] CRAN (R 3.6.3)
#> RMariaDB 1.0.8 2019-12-18 [1] CRAN (R 3.6.3)
#> rmarkdown 2.1 2020-01-20 [1] CRAN (R 3.6.3)
#> rprojroot 1.3-2 2018-01-03 [1] CRAN (R 3.6.3)
#> sessioninfo 1.1.1 2018-11-05 [1] CRAN (R 3.6.3)
#> stringi 1.4.6 2020-02-17 [1] CRAN (R 3.6.3)
#> stringr 1.4.0 2019-02-10 [1] CRAN (R 3.6.3)
#> testthat 2.3.2.9000 2020-03-20 [1] local
#> tibble 3.0.1 2020-04-20 [1] CRAN (R 3.6.3)
#> tidyselect 1.0.0 2020-01-27 [1] CRAN (R 3.6.3)
#> usethis 1.6.1 2020-04-29 [1] CRAN (R 3.6.3)
#> vctrs 0.2.4 2020-03-10 [1] CRAN (R 3.6.3)
#> withr 2.2.0 2020-04-20 [1] CRAN (R 3.6.3)
#> xfun 0.13 2020-04-13 [1] CRAN (R 3.6.3)
#> yaml 2.2.1 2020-02-01 [1] CRAN (R 3.6.3)
#>
#> [1] /home/kirill/R/x86_64-pc-linux-gnu-library/3.6
#> [2] /usr/local/lib/R/site-library
#> [3] /usr/lib/R/site-library
#> [4] /usr/lib/R/library |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The symptoms are pretty weird. It seems that with the dev version of dbplyr the
sql_escape_ident()
generic isn't routed to the correctdbQuoteIdentifier()
call. Haven't had time to investigate yet.CRAN version
Created on 2020-05-04 by the reprex package (v0.3.0)
Session info
dev version
Created on 2020-05-04 by the reprex package (v0.3.0)
Session info
The text was updated successfully, but these errors were encountered: