Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate first edition in dbplyr_fallback #507

Closed
hadley opened this issue Oct 1, 2020 · 3 comments · Fixed by #829
Closed

Deprecate first edition in dbplyr_fallback #507

hadley opened this issue Oct 1, 2020 · 3 comments · Fixed by #829

Comments

@hadley
Copy link
Member

hadley commented Oct 1, 2020

Needs minor version bump; must happen after April 1, 2021.

@mgirlich
Copy link
Collaborator

mgirlich commented Apr 6, 2022

@hadley I'm not quite sure how the deprecation should look like. Can you take care of that so that we can include into the next release?

@hadley
Copy link
Member Author

hadley commented Apr 6, 2022

Notes to self:

  • Details of overall process in https://dbplyr.tidyverse.org/articles/backend-2.html
  • So probably needs some warning in dbplyr_fallback() if the edition is 1, encouraging the user to upgrade the package. Not sure how to tell them which package to upgrade. Maybe inspect con?

@hadley
Copy link
Member Author

hadley commented Apr 6, 2022

@mgirlich it's likely to be at least 10 days before I can get to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants