Skip to content

Retrocompatibility with Oracle prior to version 12 #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 29, 2023

Conversation

JeremyPasco
Copy link
Contributor

Hi, sadly french public hospitals are full of very old Oracle DB instances (11.2 or even lower).
The current implementation of Oracle backend makes use of FETCH to limit the number of retrieved rows. FETCH has been introduced since v12.

The older way to limit rows was a simple WHERE ROWNUM <= {limit} which still works with recent Oracle versions. IMO, the main reason to use FETCH was to allow an offset, which is out of scope here. Then, could you turn back to the ROWNUM way please?

@mgirlich mgirlich merged commit 88fda02 into tidyverse:main Jun 29, 2023
@mgirlich
Copy link
Collaborator

Thanks for the PR. Usually it doesn't make much sense to support such old versions but this seemed like a small enough change.

@hadley
Copy link
Member

hadley commented Jan 17, 2024

Unfortunately that SQL is not equivalent to the previous translation, as in #1436, so I think we might need to revert this change.

hadley added a commit that referenced this pull request Feb 15, 2024
If ROWNUM is used, we need to wrap it in a subquery, and I don't think that's worth it, given that the version of Oracle that supports FETCH FIRST is now 10 years old.

Fixes #1436
hadley added a commit that referenced this pull request Feb 20, 2024
If ROWNUM is used, we need to wrap it in a subquery, and I don't think that's worth it, given that the version of Oracle that supports FETCH FIRST is now 10 years old.

Fixes #1436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants