Hive translations for window functions were no more working

[cderv]

This comes from a question on community.rstudio.com

In dbplyr 1.3.0

library(dplyr)
library(dbplyr)
tab <- tbl_lazy(iris, src = simulate_hive())
query <- tab %>%
  group_by(Species) %>%
  filter(row_number() == 1L)
query %>% show_query()
<SQL> SELECT `Sepal.Length`, `Sepal.Width`, `Petal.Length`, `Petal.Width`, `Species`
FROM (SELECT `Sepal.Length`, `Sepal.Width`, `Petal.Length`, `Petal.Width`, `Species`, row_number() OVER (PARTITION BY `Species`) AS `zzz1`
FROM `df`) `ohjggmqvbj`
WHERE (`zzz1` = 1)

With 1.4.0

tab <- tbl_lazy(iris, src = simulate_hive())
query <- tab %>%
  group_by(Species) %>%
  filter(row_number() == 1L)
query %>% show_query()
<SQL>
SELECT *
FROM `df`
WHERE (row_number() = 1)

A git bisect points to this commit: f4fcfdc. This comes from a small typo - odbc window function were no more used.

This PR changes that and now it is working as before

tab <- tbl_lazy(iris, src = simulate_hive())
query <- tab %>%
  group_by(Species) %>%
  filter(row_number() == 1L)
query %>% show_query()
<SQL>
SELECT `Sepal.Length`, `Sepal.Width`, `Petal.Length`, `Petal.Width`, `Species`
FROM (SELECT `Sepal.Length`, `Sepal.Width`, `Petal.Length`, `Petal.Width`, `Species`, ROW_NUMBER() OVER (PARTITION BY `Species`) AS `zzz1`
FROM `df`) `dbplyr_001`
WHERE (`zzz1` = 1)

I can add tests later if you want. There are not so many tests for hive curently, and nothing about window function

[hadley]

A news bullet is probably enough for now.

[hadley]

Thanks!