Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary calls to dbQuoteIdentifier() #298

Closed
wants to merge 1 commit into from
Closed

Avoid unnecessary calls to dbQuoteIdentifier() #298

wants to merge 1 commit into from

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented May 8, 2019

to reduce noise when logging DBI calls.

@hadley
Copy link
Member

hadley commented May 30, 2019

It seems odd to log calls to dbQuoteIdentifier()?

@krlmlr krlmlr mentioned this pull request Jul 21, 2019
Open
@krlmlr
Copy link
Member Author

krlmlr commented Jul 21, 2019

In general yes, but it may be helpful for those DBI tests that test quoting and unquoting.

I'll fix in DBIlog.

@krlmlr krlmlr closed this Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krlmlr @hadley